linux-kernel - Re: [PATCH v2] ubifs: ubifs to export filesystem error counters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 12 Nov 2021 18:13:30 -0800 (PST)
From:   Stefan Schaeckeler <schaecsn@....net>
To:     richard@....at
CC:     linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org,
        sschaeck@...co.com
Subject: Re: [PATCH v2] ubifs: ubifs to export filesystem error counters

Hello Richard,

> > Not all ubifs filesystem errors are propagated to userspace.
> >
> > Export bad magic, bad node and crc errors via sysfs. This allows userspace
> > to notice filesystem errors:
> >
> > /sys/fs/ubifs/ubiX_Y/errors_magic
> > /sys/fs/ubifs/ubiX_Y/errors_node
> > /sys/fs/ubifs/ubiX_Y/errors_crc
> >
> > The counters are reset to 0 with a remount.
> >
> > Signed-off-by: Stefan Schaeckeler <sschaeck@...co.com>
> > ---
> > Changes in v2:
> >  - merged sysfs.h header into ubifs.h.
> >  - io.c: wrapped incrementing error counters into new functions
> >    record_*_error().
> >  - sysfs.c: removed sysfs write callback for clearing stats.
> >  - sysfs.c: ubifs_sysfs_register(): free c->stats on error.
> >  - sysfs.c: ubifs_attr_show(): use sysfs_emit().
> >
> > fs/ubifs/Makefile |   2 +-
> > fs/ubifs/io.c     |  21 +++++++
> > fs/ubifs/super.c  |  16 ++++-
> > fs/ubifs/sysfs.c  | 153 ++++++++++++++++++++++++++++++++++++++++++++++
> > fs/ubifs/ubifs.h  |  35 +++++++++++
> > 5 files changed, 225 insertions(+), 2 deletions(-)
> > create mode 100644 fs/ubifs/sysfs.c
>
> Queued for 5.16.

The merge window for 5.16 is about to close. May I point out that, as far as I
can tell, you have not sent a pull request for ubifs, yet.

 Stefan