linux-kernel - [PATCH] checkpatch: Remove cvs keyword check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 27 Oct 2021 02:16:37 +0300
From:   Kari Argillander <kari.argillander@...il.com>
To:     apw@...onical.com, joe@...ches.com
Cc:     Kari Argillander <kari.argillander@...il.com>,
        dwaipayanray1@...il.com, lukas.bulwahn@...il.com,
        linux-kernel@...r.kernel.org, ntfs3@...ts.linux.dev
Subject: [PATCH] checkpatch: Remove cvs keyword check

Time has pass and we do not need these anymore as almost all people are
using git now days. Those who use cvs for kernel development probably
will handle cvs pretty well already so this check is not needed anymore.

Signed-off-by: Kari Argillander <kari.argillander@...il.com>
---

If someona nack about this can you also help howto fix false alarms in
fs/ntfs3/ by this cvs check. We need to use $Log in comments as it is
real name. I'm also triccered to see these false alarms. I'm not
familier with perl regex syntax and do not really understand what we
are trying to do here. Maybe also because I do not know CVS very well.

I can do patch or someone else can do it. I just want this "problem"
away as it has been sitting my todo list too long.

---
 Documentation/dev-tools/checkpatch.rst | 5 -----
 scripts/checkpatch.pl                  | 6 ------
 2 files changed, 11 deletions(-)

diff --git a/Documentation/dev-tools/checkpatch.rst b/Documentation/dev-tools/checkpatch.rst
index f0956e9ea2d8..08e53ec02f48 100644
--- a/Documentation/dev-tools/checkpatch.rst
+++ b/Documentation/dev-tools/checkpatch.rst
@@ -1105,11 +1105,6 @@ Others
     The patch seems to be corrupted or lines are wrapped.
     Please regenerate the patch file before sending it to the maintainer.
 
-  **CVS_KEYWORD**
-    Since linux moved to git, the CVS markers are no longer used.
-    So, CVS style keywords ($Id$, $Revision$, $Log$) should not be
-    added.
-
   **DEFAULT_NO_BREAK**
     switch default case is sometimes written as "default:;".  This can
     cause new cases added below default to be defective.
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 461d4221e4a4..6d65b748ac20 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -4017,12 +4017,6 @@ sub process {
 			}
 		}
 
-# check for RCS/CVS revision markers
-		if ($rawline =~ /^\+.*\$(Revision|Log|Id)(?:\$|)/) {
-			WARN("CVS_KEYWORD",
-			     "CVS style keyword markers, these will _not_ be updated\n". $herecurr);
-		}
-
 # check for old HOTPLUG __dev<foo> section markings
 		if ($line =~ /\b(__dev(init|exit)(data|const|))\b/) {
 			WARN("HOTPLUG_SECTION",
-- 
2.25.1