linux-kernel - Re: [PATCH] checkpatch: Remove cvs keyword check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <868c29d45172a151b6a751de4ba32165cbf7a4cc.camel@perches.com>
Date:   Tue, 26 Oct 2021 17:26:21 -0700
From:   Joe Perches <joe@...ches.com>
To:     Kari Argillander <kari.argillander@...il.com>, apw@...onical.com
Cc:     dwaipayanray1@...il.com, lukas.bulwahn@...il.com,
        linux-kernel@...r.kernel.org, ntfs3@...ts.linux.dev
Subject: Re: [PATCH] checkpatch: Remove cvs keyword check

On Wed, 2021-10-27 at 02:16 +0300, Kari Argillander wrote:
> Time has pass and we do not need these anymore as almost all people are
> using git now days. Those who use cvs for kernel development probably
> will handle cvs pretty well already so this check is not needed anymore.

I think it's a relatively harmless thing to keep.

> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -4017,12 +4017,6 @@ sub process {
>  			}
>  		}
>  
> -# check for RCS/CVS revision markers
> -		if ($rawline =~ /^\+.*\$(Revision|Log|Id)(?:\$|)/) {

Looks like this would be better using

		if ($rawline =~ /^\+.*\b\$(?:Revision|Log|Id)\$?\b/) {

> -			WARN("CVS_KEYWORD",
> -			     "CVS style keyword markers, these will _not_ be updated\n". $herecurr);