linux-kernel - drivers/clk/sunxi-ng: suspected missing null check for callsite of clk_hw_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <TYCP286MB11881B25B95E38A0673B3CA78A849@TYCP286MB1188.JPNP286.PROD.OUTLOOK.COM>
Date:   Tue, 26 Oct 2021 06:47:15 +0000
From:   YE Chengfeng <cyeaa@...nect.ust.hk>
To:     "mturquette@...libre.com" <mturquette@...libre.com>,
        "sboyd@...nel.org" <sboyd@...nel.org>,
        "mripard@...nel.org" <mripard@...nel.org>,
        "wens@...e.org" <wens@...e.org>,
        "jernej.skrabec@...il.com" <jernej.skrabec@...il.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: drivers/clk/sunxi-ng: suspected missing null check for callsite of
 clk_hw_get_parent 

Hi,

https://github.com/torvalds/linux/blob/5bfc75d92efd494db37f5c4c173d3639d4772966/drivers/clk/sunxi-ng/ccu_gate.c#L101
https://github.com/torvalds/linux/blob/master/drivers/clk/sunxi-ng/ccu_mux.c#L93

Our experimental static analysis tool detects a null-ptr-reference problem. It could be false positive, we report this to you just in case.

In these two call sites of clk_hw_get_parent, the return pointer is not null-check. We are not familiar with the code, and don't know whether it would be a potential null pointer dereference problem. Would you like to spare some time to have a look at it?

Thanks so much,
Chengfeng