linux-kernel - RE: [PATCH v2] xen: Fix implicit type conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR08MB30564CABD02DBB0F17BBDCDD92849@VI1PR08MB3056.eurprd08.prod.outlook.com>
Date:   Tue, 26 Oct 2021 09:59:34 +0000
From:   Jiamei Xie <Jiamei.Xie@....com>
To:     Juergen Gross <jgross@...e.com>,
        Jiasheng Jiang <jiasheng@...as.ac.cn>,
        "boris.ostrovsky@...cle.com" <boris.ostrovsky@...cle.com>,
        "sstabellini@...nel.org" <sstabellini@...nel.org>
CC:     "xen-devel@...ts.xenproject.org" <xen-devel@...ts.xenproject.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2] xen: Fix implicit type conversion



> -----Original Message-----
> From: Xen-devel <xen-devel-bounces@...ts.xenproject.org> On Behalf Of
> Juergen Gross
> Sent: 2021年10月26日 15:36
> To: Jiasheng Jiang <jiasheng@...as.ac.cn>; boris.ostrovsky@...cle.com;
> sstabellini@...nel.org
> Cc: xen-devel@...ts.xenproject.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH v2] xen: Fix implicit type conversion
> 
> On 26.10.21 09:32, Jiasheng Jiang wrote:
> > The variable 'i' is defined as UINT.
> > However in the for_each_possible_cpu, its value is assigned to -1.
> > That doesn't make sense and in the cpumask_next() it is implicitly
> > type conversed to INT.
> > It is universally accepted that the implicit type conversion is
> > terrible.
> > Also, having the good programming custom will set an example for
> > others.
> > Thus, it might be better to change the definition of 'i' from UINT
> > to INT.
> >
> > Fixes: 3fac101 ("xen: Re-upload processor PM data to hypervisor after S3
> resume (v2)")
> > Signed-off-by: Jiasheng Jiang <jiasheng@...as.ac.cn>
> 
> Reviewed-by: Juergen Gross <jgross@...e.com>
> 
> 
> Juergen

[Jiamei Xie] 
Reviewed-by: Jiamei Xie <jiamei.xie@....com>