linux-kernel - Re: [PATCH v5 15/15] clk: use clk_core_get_rate_recalc() in clk_rate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <46a6581e-a65e-f280-7f4b-a793229068eb@microchip.com>
Date:   Wed, 27 Oct 2021 07:01:52 +0000
From:   <Claudiu.Beznea@...rochip.com>
To:     <sboyd@...nel.org>, <alexandre.belloni@...tlin.com>,
        <Ludovic.Desroches@...rochip.com>, <mturquette@...libre.com>,
        <Nicolas.Ferre@...rochip.com>
CC:     <linux-clk@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 15/15] clk: use clk_core_get_rate_recalc() in
 clk_rate_get()

On 27.10.2021 04:26, Stephen Boyd wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Quoting Claudiu Beznea (2021-10-11 04:27:19)
>> In case clock flags contains CLK_GET_RATE_NOCACHE the clk_rate_get()
>> will return the cached rate. Thus, use clk_core_get_rate_recalc() which
>> takes proper action when clock flags contains CLK_GET_RATE_NOCACHE.
>>
>> Signed-off-by: Claudiu Beznea <claudiu.beznea@...rochip.com>
>> ---
>>  drivers/clk/clk.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
>> index 65508eb89ec9..64838754cdef 100644
>> --- a/drivers/clk/clk.c
>> +++ b/drivers/clk/clk.c
>> @@ -3108,7 +3108,7 @@ static int clk_rate_get(void *data, u64 *val)
>>  {
>>         struct clk_core *core = data;
>>
>> -       *val = core->rate;
>> +       *val = clk_core_get_rate_recalc(core);
> 
> We need to grab the prepare lock now. I'll fix it when applying.

Thank you!

>