lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 27 Oct 2021 09:30:55 +0200 From: Luca Ceresoli <luca@...aceresoli.net> To: Rob Herring <robh@...nel.org>, devicetree@...r.kernel.org Cc: linux-kernel@...r.kernel.org, Masahiro Yamada <masahiroy@...nel.org> Subject: Re: [PATCH] dt-bindings: Add a help message when dtschema tools are missing Hi Rob, thanks for this patch! On 26/10/21 19:18, Rob Herring wrote: > The dtschema version check works, but is not that clear when dtschema is > neither installed nor in the PATH. Add a separate check and message if Nit: I think it should say "either not installed or not in the PATH". > dt-doc-validate is not found. > > Cc: Luca Ceresoli <luca@...aceresoli.net> > Cc: Masahiro Yamada <masahiroy@...nel.org> > Signed-off-by: Rob Herring <robh@...nel.org> > --- > Documentation/devicetree/bindings/Makefile | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/Makefile b/Documentation/devicetree/bindings/Makefile > index 8d6d912c6a6a..001b4f62b741 100644 > --- a/Documentation/devicetree/bindings/Makefile > +++ b/Documentation/devicetree/bindings/Makefile > @@ -9,6 +9,10 @@ DT_SCHEMA_MIN_VERSION = 2021.2.1 > > PHONY += check_dtschema_version > check_dtschema_version: > + @which $(DT_DOC_CHECKER) >/dev/null || \ > + { echo "Error: '$(DT_DOC_CHECKER)' not found!" \ > + "\nEnsure dtschema python package is installed and in your PATH." \ > + "\nCurrent PATH is:\n$$PATH\n" >&2; false; } You need 'echo -e' for the '\n'. Otherwise looks and works well. -- Luca
Powered by blists - more mailing lists