linux-kernel - Re: [PATCH] KVM: arm64: Remove unused TRNG_NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211027073707.GB22231@willie-the-truck>
Date:   Wed, 27 Oct 2021 08:37:07 +0100
From:   Will Deacon <will@...nel.org>
To:     Qian Cai <quic_qiancai@...cinc.com>
Cc:     Marc Zyngier <maz@...nel.org>, James Morse <james.morse@....com>,
        Ard Biesheuvel <ardb@...nel.org>,
        Alexandru Elisei <alexandru.elisei@....com>,
        Suzuki K Poulose <suzuki.poulose@....com>,
        Catalin Marinas <catalin.marinas@....com>,
        linux-arm-kernel@...ts.infradead.org, kvmarm@...ts.cs.columbia.edu,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] KVM: arm64: Remove unused TRNG_NO_ENTROPY

On Tue, Oct 26, 2021 at 05:09:13PM -0400, Qian Cai wrote:
> TRNG_NO_ENTROPY was unused when introduced and now. This is also caught by
> GCC (W=2):
> 
> arch/arm64/kvm/trng.c:17: warning: macro "TRNG_NO_ENTROPY" is not used [-Wunused-macros]
>    17 | #define TRNG_NO_ENTROPY   ((unsigned long)-3)

This return value is defined by the TRNG SMCCC spec (Arm DEN0098) so I'd
rather just keep it around given that it's not causing any problems.

Will