linux-kernel - Re: [PATCH] ima/evm: mark evm_fixmode as __ro_after

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f675255eae2bc97bc571f7e798a952ea3d24e4d6.camel@linux.ibm.com>
Date:   Wed, 27 Oct 2021 20:27:06 -0400
From:   Mimi Zohar <zohar@...ux.ibm.com>
To:     Austin Kim <austindh.kim@...il.com>, jmorris@...ei.org,
        serge@...lyn.com
Cc:     linux-integrity@...r.kernel.org,
        linux-security-module@...r.kernel.org,
        linux-kernel@...r.kernel.org, austin.kim@....com,
        kernel-team@....com
Subject: Re: [PATCH] ima/evm: mark evm_fixmode as __ro_after_init

Hi Austin,

The subject line should be just "evm:".

On Tue, 2021-10-26 at 23:43 +0100, Austin Kim wrote:
> From: Austin Kim <austin.kim@....com>
> 
> evm_fixmode global variable is never modified
> outside initcalls, so declaring it with __ro_after_init is better.

Please properly format the text.  From
Documentation/process/submitting-patches.rst:

  - The body of the explanation, line wrapped at 75 columns, which will
    be copied to the permanent changelog to describe this patch.

> 
> Signed-off-by: Austin Kim <austin.kim@....com>

Otherwise,
Reviewed-by: Mimi Zohar <zohar@...ux.ibm.com>