linux-kernel - Re: [PATCH] ima/evm: mark evm_fixmode as __ro_after

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADLLry7fhBazjgBJovqAwxyVdvUPLifLRxgwZwSAifQY6HGThg@mail.gmail.com>
Date:   Thu, 28 Oct 2021 10:48:46 +0900
From:   Austin Kim <austindh.kim@...il.com>
To:     Mimi Zohar <zohar@...ux.ibm.com>
Cc:     James Morris <jmorris@...ei.org>,
        "Serge E. Hallyn" <serge@...lyn.com>,
        linux-integrity@...r.kernel.org,
        linux-security-module <linux-security-module@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        김동현 <austin.kim@....com>,
        kernel-team@....com
Subject: Re: [PATCH] ima/evm: mark evm_fixmode as __ro_after_init

Hello Mimi,

2021년 10월 28일 (목) 오전 9:27, Mimi Zohar <zohar@...ux.ibm.com>님이 작성:
>
> Hi Austin,
>
> The subject line should be just "evm:".
>
> On Tue, 2021-10-26 at 23:43 +0100, Austin Kim wrote:
> > From: Austin Kim <austin.kim@....com>
> >
> > evm_fixmode global variable is never modified
> > outside initcalls, so declaring it with __ro_after_init is better.
>
> Please properly format the text.  From
> Documentation/process/submitting-patches.rst:
>
>   - The body of the explanation, line wrapped at 75 columns, which will
>     be copied to the permanent changelog to describe this patch.

Thanks for feedback.
let me resend the patch after updating "subject line" and checking text-format.

BR,
Austin Kim

>
> >
> > Signed-off-by: Austin Kim <austin.kim@....com>
>
> Otherwise,
> Reviewed-by: Mimi Zohar <zohar@...ux.ibm.com>
>