linux-kernel - Re: [RFC] mmc: core: transplant ti,wl1251 quirks from to be retired omap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 28 Oct 2021 12:07:27 +0200
From:   "H. Nikolaus Schaller" <hns@...delico.com>
To:     Jérôme Pouiller <jerome.pouiller@...abs.com>
Cc:     Ulf Hansson <ulf.hansson@...aro.org>,
        Avri Altman <avri.altman@....com>,
        Shawn Lin <shawn.lin@...k-chips.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bean Huo <beanhuo@...ron.com>, linux-mmc@...r.kernel.org,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Discussions about the Letux Kernel 
        <letux-kernel@...nphoenux.org>, kernel@...a-handheld.com,
        Tony Lindgren <tony@...mide.com>,
        Linux-OMAP <linux-omap@...r.kernel.org>
Subject: Re: [RFC] mmc: core: transplant ti,wl1251 quirks from to be retired
 omap_hsmmc



> Am 28.10.2021 um 11:55 schrieb Jérôme Pouiller <jerome.pouiller@...abs.com>:
> 
> On Thursday 28 October 2021 11:40:59 CEST H. Nikolaus Schaller wrote:
>>> Am 28.10.2021 um 10:59 schrieb Jérôme Pouiller <jerome.pouiller@...abs.com>:
>>> On Thursday 28 October 2021 09:08:50 CEST H. Nikolaus Schaller wrote:
>>> 
>>>>> Let me have a closer look - and for sure, I am willing to help if needed.
>>> 
>>> I confirm it does not have the expected behavior. !mmc_fixup_of_compatible_match()
>>> should be mmc_fixup_of_compatible_match(), sorry.
>> 
>> Ok, I see.
>> 
>> One more question: how can I specify "ti,wl1251" in some struct mmc_fixup table?
>> Does it need another macro like MMC_FIXUP() or SDIO_FIXUP() to set the .name
>> field?
> 
> yes, I didn't provide it with my RFC. 

I see.

Starts to look like a good plan and we just have to execute it.

Please notify if you have a new version to work with (it isn't urgent since the
transplantation is only needed if omap_hsmmc is retired which depends on merge
of the new driver).

BR and thanks,
Nikolaus