linux-kernel - Re: [PATCH RESEND] ASoC: fix unmet dependencies on GPIOLIB for SND_SOC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6ff76018-309d-349e-691a-f504ca29420e@amd.com>
Date:   Thu, 28 Oct 2021 18:09:40 +0530
From:   "Mukunda,Vijendar" <vijendar.mukunda@....com>
To:     Julian Braha <julianbraha@...il.com>, broonie@...nel.org,
        perex@...ex.cz, tiwai@...e.com,
        pierre-louis.bossart@...ux.intel.com
Cc:     linux-kernel@...r.kernel.org, alsa-devel@...a-project.org,
        fazilyildiran@...il.com
Subject: Re: [PATCH RESEND] ASoC: fix unmet dependencies on GPIOLIB for
 SND_SOC_DMIC

On 10/28/21 12:18 AM, Julian Braha wrote:
> When SND_SOC_AMD_RENOIR_MACH or SND_SOC_AMD_RV_RT5682_MACH
> are selected, and GPIOLIB is not selected, Kbuild gives
> the following warnings, respectively:
> 
> WARNING: unmet direct dependencies detected for SND_SOC_DMIC
>   Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && GPIOLIB [=n]
>   Selected by [y]:
>   - SND_SOC_AMD_RENOIR_MACH [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_AMD_RENOIR [=y]
> 
> and
> 
> WARNING: unmet direct dependencies detected for SND_SOC_MAX98357A
>   Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && GPIOLIB [=n]
>   Selected by [y]:
>   - SND_SOC_AMD_RV_RT5682_MACH [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_AMD_ACP3x [=y] && I2C [=y] && CROS_EC [=y]
> 
> This is because SND_SOC_DMIC and SND_SOC_MAX98357A are
> selected by SND_SOC_AMD_RV_RT5682_MACH and SND_SOC_AMD_RENOIR_MACH,
> respectively. However, neither of the selectors depend on or select GPIOLIB,
> despite their selectees depending on GPIOLIB.
> 
> These unmet dependency bugs were detected by Kismet,
> a static analysis tool for Kconfig. Please advise if this
> is not the appropriate solution.
> 
> Signed-off-by: Julian Braha <julianbraha@...il.com>
> ---
>  sound/soc/amd/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig
> index 56e7c079deac..2c6af3f8f296 100644
> --- a/sound/soc/amd/Kconfig
> +++ b/sound/soc/amd/Kconfig
> @@ -38,7 +38,7 @@ config SND_SOC_AMD_RV_RT5682_MACH
>  	select I2C_CROS_EC_TUNNEL
>  	select SND_SOC_RT1015
>  	select SND_SOC_RT1015P
> -	depends on SND_SOC_AMD_ACP3x && I2C && CROS_EC
> +	depends on SND_SOC_AMD_ACP3x && I2C && CROS_EC && GPIOLIB
>  	help
>  	 This option enables machine driver for RT5682 and MAX9835.
> 
> @@ -51,7 +51,7 @@ config SND_SOC_AMD_RENOIR
>  config SND_SOC_AMD_RENOIR_MACH
>  	tristate "AMD Renoir support for DMIC"
>  	select SND_SOC_DMIC
> -	depends on SND_SOC_AMD_RENOIR
> +	depends on SND_SOC_AMD_RENOIR && GPIOLIB
For Renoir platform, DMIC driver selected for registering codec dai with
ASOC. No additional functionality handled related to GPIO.
Do you still see necessity adding GPIOLIB dependency?

>  	help
>  	 This option enables machine driver for DMIC
> 
> --
> 2.30.2
>