linux-kernel - [PATCH] ARM: davinci: fix unmet dependency on PINCTRL for PINCTRL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20211029220713.24420-1-julianbraha@gmail.com>
Date:   Fri, 29 Oct 2021 18:07:13 -0400
From:   Julian Braha <julianbraha@...il.com>
To:     nsekhar@...com, brgl@...ev.pl, linux@...linux.org.uk
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        fazilyildiran@...il.com
Subject: [PATCH] ARM: davinci: fix unmet dependency on PINCTRL for PINCTRL_SINGLE

When ARCH_DAVINCI is enabled and PINCTRL is disabled,
Kbuild gives the following warning:

WARNING: unmet direct dependencies detected for PINCTRL_SINGLE
  Depends on [n]: PINCTRL [=n] && OF [=y] && HAS_IOMEM [=y]
  Selected by [y]:
  - ARCH_DAVINCI [=y] && ARCH_MULTI_V5 [=y]

This is because ARCH_DAVINCI selects PINCTRL_SINGLE
without selecting or depending on PINCTRL, despite
PINCTRL_SINGLE depending on PINCTRL.

This unmet dependency was detected by Kismet, a
static analysis tool for Kconfig. Please advise
if this is not the appropriate solution.

Signed-off-by: Julian Braha <julianbraha@...il.com>
---
 arch/arm/mach-davinci/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-davinci/Kconfig b/arch/arm/mach-davinci/Kconfig
index 1d3aef84287d..a9ae3ba4536c 100644
--- a/arch/arm/mach-davinci/Kconfig
+++ b/arch/arm/mach-davinci/Kconfig
@@ -9,7 +9,7 @@ menuconfig ARCH_DAVINCI
 	select PM_GENERIC_DOMAINS_OF if PM && OF
 	select REGMAP_MMIO
 	select RESET_CONTROLLER
-	select PINCTRL_SINGLE
+	imply PINCTRL_SINGLE
 
 if ARCH_DAVINCI
 
-- 
2.30.2