linux-kernel - Re: [PATCH] soc/tegra: fix unmet dependency on DMADEVICES for TEGRA20_APB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <27e1ba98-80ef-aa89-1527-b50a9ea33436@gmail.com>
Date:   Sat, 30 Oct 2021 01:21:27 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Arnd Bergmann <arnd@...db.de>, Julian Braha <julianbraha@...il.com>
Cc:     Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        "open list:TEGRA ARCHITECTURE SUPPORT" <linux-tegra@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        fazilyildiran@...il.com
Subject: Re: [PATCH] soc/tegra: fix unmet dependency on DMADEVICES for
 TEGRA20_APB_DMA

30.10.2021 01:07, Arnd Bergmann пишет:
> On Fri, Oct 29, 2021 at 10:59 PM Julian Braha <julianbraha@...il.com> wrote:
>>
>>  drivers/soc/tegra/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/soc/tegra/Kconfig b/drivers/soc/tegra/Kconfig
>> index 8b53ed1cc67e..ee7f631933c2 100644
>> --- a/drivers/soc/tegra/Kconfig
>> +++ b/drivers/soc/tegra/Kconfig
>> @@ -136,7 +136,7 @@ config SOC_TEGRA_FUSE
>>         def_bool y
>>         depends on ARCH_TEGRA
>>         select SOC_BUS
>> -       select TEGRA20_APB_DMA if ARCH_TEGRA_2x_SOC
>> +       select TEGRA20_APB_DMA if DMADEVICES && ARCH_TEGRA_2x_SOC
>>
> 
> Is this actually a compile-time dependency? If the fuse driver merely
> uses DMA and assumes that the TEGRA20_APB_DMA driver is the one
> providing this functionality, the 'select' should be removed here.

There was a patch that did it already [1], not sure what happened to it.

[1] https://lore.kernel.org/all/20200923003421.4561-1-digetx@gmail.com/