linux-kernel - [PATCH] s390: add <linux/minmax.h> to <asm/facility.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 28 Oct 2021 17:26:33 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     linux-kernel@...r.kernel.org
Cc:     Randy Dunlap <rdunlap@...radead.org>,
        Linux Kernel Functional Testing <lkft@...aro.org>,
        Naresh Kamboju <naresh.kamboju@...aro.org>,
        Heiko Carstens <hca@...ux.ibm.com>,
        Vasily Gorbik <gor@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ibm.com>,
        linux-s390@...r.kernel.org
Subject: [PATCH] s390: add <linux/minmax.h> to <asm/facility.h>

S390's <asm/facility.h> uses the min_t() macro, so it should
include <linux/minmax.h> to avoid build errors.

In file included from arch/s390/pci/pci_insn.c:12:
arch/s390/include/asm/facility.h: In function '__stfle':
arch/s390/include/asm/facility.h:98:22: error: implicit declaration of
function 'min_t' [-Werror=implicit-function-declaration]
   98 |                 nr = min_t(unsigned long, (nr + 1) * 8, size * 8);
arch/s390/include/asm/facility.h:98:28: error: expected expression
before 'unsigned'
   98 |                 nr = min_t(unsigned long, (nr + 1) * 8, size * 8);


Fixes: 4f18d869ffd0 ("s390: fix stfle zero padding")
Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
Reported-by: Linux Kernel Functional Testing <lkft@...aro.org>
Cc: Naresh Kamboju <naresh.kamboju@...aro.org>
Cc: Heiko Carstens <hca@...ux.ibm.com>
Cc: Vasily Gorbik <gor@...ux.ibm.com>
Cc: Christian Borntraeger <borntraeger@...ibm.com>
Cc: linux-s390@...r.kernel.org
---
 arch/s390/include/asm/facility.h |    1 +
 1 file changed, 1 insertion(+)

--- linux-next-20211028.orig/arch/s390/include/asm/facility.h
+++ linux-next-20211028/arch/s390/include/asm/facility.h
@@ -9,6 +9,7 @@
 #define __ASM_FACILITY_H
 
 #include <asm/facility-defs.h>
+#include <linux/minmax.h>
 #include <linux/string.h>
 #include <linux/preempt.h>
 #include <asm/lowcore.h>