linux-kernel - Re: [PATCH] s390: add <linux/minmax.h> to <asm/facility.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 29 Oct 2021 12:21:27 +0200
From:   Vasily Gorbik <gor@...ux.ibm.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-kernel@...r.kernel.org,
        Linux Kernel Functional Testing <lkft@...aro.org>,
        Naresh Kamboju <naresh.kamboju@...aro.org>,
        Heiko Carstens <hca@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ibm.com>,
        linux-s390@...r.kernel.org
Subject: Re: [PATCH] s390: add <linux/minmax.h> to <asm/facility.h>

On Thu, Oct 28, 2021 at 05:26:33PM -0700, Randy Dunlap wrote:
> S390's <asm/facility.h> uses the min_t() macro, so it should
> include <linux/minmax.h> to avoid build errors.
> 
> In file included from arch/s390/pci/pci_insn.c:12:
> arch/s390/include/asm/facility.h: In function '__stfle':
> arch/s390/include/asm/facility.h:98:22: error: implicit declaration of
> function 'min_t' [-Werror=implicit-function-declaration]
>    98 |                 nr = min_t(unsigned long, (nr + 1) * 8, size * 8);
> arch/s390/include/asm/facility.h:98:28: error: expected expression
> before 'unsigned'
>    98 |                 nr = min_t(unsigned long, (nr + 1) * 8, size * 8);

Thank you, but it has been addressed in latest linux-next by:
https://lore.kernel.org/all/20211028170143.56523-1-andriy.shevchenko@linux.intel.com/