linux-kernel - RE: [PATCH v3] scsi: ufshpb: Opt out pre-reqs from HPB2.0 flows

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 30 Oct 2021 10:57:09 +0000
From:   Avri Altman <Avri.Altman@....com>
To:     Avri Altman <Avri.Altman@....com>, Bean Huo <huobean@...il.com>,
        "James E . J . Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>
CC:     "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Bart Van Assche <bvanassche@....org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Bean Huo <beanhuo@...ron.com>,
        Daejun Park <daejun7.park@...sung.com>,
        James Bottomley <James.Bottomley@...senPartnership.com>
Subject: RE: [PATCH v3] scsi: ufshpb: Opt out pre-reqs from HPB2.0 flows

 
> 
> > >
> > > +       ufshpb_prep(hba, lrbp);
> >
> >
> > it is better to add one line comment to highlight that HPB preperation
> > failure will not impact original read request.
> Will do.
> 
> >
> > Reviewed-by: Bean Huo <beanhuo@...ron.com>
> > Tested-by: Bean Huo <beanhuo@...ron.com>
> Thanks.
> 
> We are still not handling max-single-cmd properly.
> I will issue another fix later on this week, once Martin picks this one.
Martin,
Alternatively, would you prefer that instead of all that, I'll submit a fix to facdc632bb5f (scsi: ufs: ufshpb: Remove HPB2.0 flows),
which you already picked?

Thanks,
Avri

> 
> Thanks,
> Avri
> >
> >
> > Bean
> >
> >
> >