lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 30 Oct 2021 08:20:50 -0300 From: Maíra Canal <maira.canal@....br> To: Uwe Kleine-König <u.kleine-koenig@...gutronix.de> Cc: Sean Young <sean@...s.org>, mchehab@...nel.org, thierry.reding@...il.com, Lee Jones <lee.jones@...aro.org>, linux-media@...r.kernel.org, linux-kernel@...r.kernel.org, linux-pwm@...r.kernel.org, kernel@...gutronix.de Subject: Re: [PATCH] media: ir-rx51: Switch to atomic PWM API Hello Uwe, > Doing this here introduces a change in behaviour. Better do this after > pwm_get(). I didn't really get this feedback. Isn't pwm_init_state after pwm_get? Or should it be before the error treatment of pwm_get? > Conceptually this last hunk belongs in a separate patch. And you don't > need to repeat PTR_ERR(pwm), as dev_err_probe already emits this > information. So > > return dev_err_probe(&dev->dev, PTR_ERR(pwm), "pwm_get failed\n"); > > should be fine. Thank you for the suggestion! I will fix it on v2. Maíra
Powered by blists - more mailing lists