linux-kernel - Re: [PATCH] media: ir-rx51: Switch to atomic PWM API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211031174347.57rnaimaagj43u2q@pengutronix.de>
Date:   Sun, 31 Oct 2021 18:43:47 +0100
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Maíra Canal <maira.canal@....br>
Cc:     linux-pwm@...r.kernel.org, Sean Young <sean@...s.org>,
        linux-kernel@...r.kernel.org, thierry.reding@...il.com,
        kernel@...gutronix.de, mchehab@...nel.org,
        Lee Jones <lee.jones@...aro.org>, linux-media@...r.kernel.org
Subject: Re: [PATCH] media: ir-rx51: Switch to atomic PWM API

On Sat, Oct 30, 2021 at 08:20:50AM -0300, Maíra Canal wrote:
> Hello Uwe,
> 
> > Doing this here introduces a change in behaviour. Better do this after
> > pwm_get().
> 
> I didn't really get this feedback. Isn't pwm_init_state after pwm_get?
> Or should it be before the error treatment of pwm_get?

It is, but it might be repeated resetting the pwm settings when the
device is reopened.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)