linux-kernel - Re: [PATCH] gpu/drm: ingenic: Remove bogus register write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <UP3T1R.6J62YIN55WCQ3@crapouillou.net>
Date:   Sat, 30 Oct 2021 21:03:30 +0100
From:   Paul Cercueil <paul@...pouillou.net>
To:     Sam Ravnborg <sam@...nborg.org>
Cc:     David Airlie <airlied@...ux.ie>, Daniel Vetter <daniel@...ll.ch>,
        linux-mips@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org,
        Christophe Branchereau <cbranchereau@...il.com>,
        list@...ndingux.net, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] gpu/drm: ingenic: Remove bogus register write

Hi,

Le sam., oct. 30 2021 at 20:49:53 +0200, Sam Ravnborg 
<sam@...nborg.org> a écrit :
> Hi Paul,
> 
> On Sat, Oct 30, 2021 at 11:00:32AM +0100, Paul Cercueil wrote:
>>  Commit 1bdb542da736 ("drm/ingenic: Simplify code by using hwdescs
>>  array") caused the dma_hwdesc_phys_f{0,1} variables to be used while
>>  uninitialized in a mmio register write, which most certainly broke 
>> the
>>  ingenic-drm driver.
>> 
>>  However, the very same patchset also submitted commit 6055466203df
>>  ("drm/ingenic: Upload palette before frame"), which restored a 
>> correct
>>  behaviour by doing the register writes in a different place in the 
>> code.
>> 
>>  What's left of this, is just to remove the bogus register writes in 
>> the
>>  probe function.
>> 
>>  Signed-off-by: Paul Cercueil <paul@...pouillou.net>
>>  Reported-by: kernel test robot <lkp@...el.com>
> 
> Thank you lkp...
> Acked-by: Sam Ravnborg <sam@...nborg.org>

Pushed to drm-misc-next.

Thanks!
-Paul