linux-kernel - Re: [PATCH net-next 1/4] net: mana: Fix the netdev_err()'s vPort argument in mana_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211030130718.3471728c@hermes.local>
Date:   Sat, 30 Oct 2021 13:07:18 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Dexuan Cui <decui@...rosoft.com>
Cc:     davem@...emloft.net, kuba@...nel.org, gustavoars@...nel.org,
        haiyangz@...rosoft.com, netdev@...r.kernel.org, kys@...rosoft.com,
        wei.liu@...nel.org, linux-kernel@...r.kernel.org,
        linux-hyperv@...r.kernel.org, shacharr@...rosoft.com,
        paulros@...rosoft.com, olaf@...fle.de, vkuznets@...hat.com
Subject: Re: [PATCH net-next 1/4] net: mana: Fix the netdev_err()'s vPort
 argument in mana_init_port()

On Fri, 29 Oct 2021 17:54:05 -0700
Dexuan Cui <decui@...rosoft.com> wrote:

> diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c b/drivers/net/ethernet/microsoft/mana/mana_en.c
> index 1417d1e72b7b..4ff5a1fc506f 100644
> --- a/drivers/net/ethernet/microsoft/mana/mana_en.c
> +++ b/drivers/net/ethernet/microsoft/mana/mana_en.c
> @@ -1599,7 +1599,8 @@ static int mana_init_port(struct net_device *ndev)
>  	err = mana_query_vport_cfg(apc, port_idx, &max_txq, &max_rxq,
>  				   &num_indirect_entries);
>  	if (err) {
> -		netdev_err(ndev, "Failed to query info for vPort 0\n");
> +		netdev_err(ndev, "Failed to query info for vPort %d\n",
> +			   port_idx);

Shouldn't port_idx have been unsigned or u16?
It is u16 in mana_port_context.