lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sun, 31 Oct 2021 00:56:59 +0300
From:   Andy Shevchenko <>
To:     Hans de Goede <>
Cc:     Mark Gross <>,
        Andy Shevchenko <>,
        Wolfram Sang <>,
        Sebastian Reichel <>,
        MyungJoo Ham <>,
        Chanwoo Choi <>,
        Ard Biesheuvel <>,
        Yauhen Kharuzhy <>,
        Tsuchiya Yuto <>,,,,,
Subject: Re: [PATCH 02/13] platform/x86: dmi_device_properties: Add setup info
 for boards with a CHT Whiskey Cove PMIC

On Sat, Oct 30, 2021 at 9:28 PM Hans de Goede <> wrote:
> Add a new "intel,cht-wc-setup" string property to the "INT34D3:00"
> i2c_client for the Whiskey Cove PMIC found on several Cherry Trail
> based devices. At least 3 setups are known:
> 1. The WC PMIC is connected to a TI BQ24292i charger, paired with
>    a Maxim MAX17047 fuelgauge + a FUSB302 USB Type-C Controller +
>    a PI3USB30532 USB switch, for a fully functional Type-C port
> 2. The WC PMIC is connected to a TI BQ25890 charger, paired with
>    a TI BQ27520 fuelgauge, for a USB-2 only Type-C port without PD
> 3. The WC PMIC is connected to a TI BQ25890 charger, paired with
>    a TI BQ27542 fuelgauge, for a micro-USB port
> Which setup is in use cannot be determined reliably from the ACPI tables
> and various drivers (extcon-intel-cht-wc.c, i2c-cht-wc.c, ...) need
> to know which setup they are dealing with.

If it's internal property only, I would rather expect it to start with
'linux,' as DWC3 does. And it's also USB related.


> +       PROPERTY_ENTRY_STRING("intel,cht-wc-setup", "bq24292i,max17047,fusb302,pi3usb30532"),

> +       PROPERTY_ENTRY_STRING("intel,cht-wc-setup", "bq25890,bq27520"),

 Besides that I'm not sure about the name of the property, maybe
'linux,cht-wc-usb-chips' or alike? And since it's a list, can we make
it a string array?

With Best Regards,
Andy Shevchenko

Powered by blists - more mailing lists