lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sun, 31 Oct 2021 01:07:09 +0300
From:   Andy Shevchenko <>
To:     Hans de Goede <>
Cc:     Mark Gross <>,
        Andy Shevchenko <>,
        Wolfram Sang <>,
        Sebastian Reichel <>,
        MyungJoo Ham <>,
        Chanwoo Choi <>,
        Ard Biesheuvel <>,
        Yauhen Kharuzhy <>,
        Tsuchiya Yuto <>,
        Platform Driver <>,
        linux-i2c <>,
        Linux PM <>,
        Linux Kernel Mailing List <>,
        linux-efi <>
Subject: Re: [PATCH 06/13] power: supply: bq25890: Add support for skipping initialization

On Sat, Oct 30, 2021 at 9:28 PM Hans de Goede <> wrote:
> On most X86/ACPI devices there is no devicetree to supply the necessary
> init-data. Instead the firmware already fully initializes the bq25890
> charger at boot.
> At support for a new "ti,skip-init" boolean property to support this.
> So far this new property is only used on X86/ACPI (non devicetree) devs,
> IOW it is not used in actual devicetree files. The devicetree-bindings
> maintainers have requested properties like these to not be added to the
> devicetree-bindings, so the new property is deliberately not added
> to the existing devicetree-bindings.

With 'ti,' prefix it can be a potential collision in name space, for
internal properties I would rather use 'linux,' one.


> +       init->write_cfg = !device_property_read_bool(bq->dev, "ti,skip-init");
> +       if (!init->write_cfg)
> +               return 0;

Why to have double negation here?
I would rather expect that you will have direct value in the structure
and do a respective check in the functions.

With Best Regards,
Andy Shevchenko

Powered by blists - more mailing lists