[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <1eb3e513-8795-6544-8ff6-964197a87eaf@canonical.com>
Date: Sun, 31 Oct 2021 22:00:22 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
To: David Virag <virag.david003@...il.com>
Cc: Tomasz Figa <tomasz.figa@...il.com>,
Sylwester Nawrocki <s.nawrocki@...sung.com>,
Linus Walleij <linus.walleij@...aro.org>,
Rob Herring <robh+dt@...nel.org>,
linux-arm-kernel@...ts.infradead.org,
linux-samsung-soc@...r.kernel.org, linux-gpio@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] pinctrl: samsung: Add Exynos7885 SoC specific data
On 31/10/2021 16:51, David Virag wrote:
> Add Samsung Exynos7885 SoC specific data to enable pinctrl support for
> all platforms based on Exynos7885.
>
> Signed-off-by: David Virag <virag.david003@...il.com>
> ---
> .../pinctrl/samsung/pinctrl-exynos-arm64.c | 81 +++++++++++++++++++
> drivers/pinctrl/samsung/pinctrl-samsung.c | 2 +
> drivers/pinctrl/samsung/pinctrl-samsung.h | 1 +
> 3 files changed, 84 insertions(+)
>
> diff --git a/drivers/pinctrl/samsung/pinctrl-exynos-arm64.c b/drivers/pinctrl/samsung/pinctrl-exynos-arm64.c
> index 6b77fd24571e..8bad82e709d3 100644
> --- a/drivers/pinctrl/samsung/pinctrl-exynos-arm64.c
> +++ b/drivers/pinctrl/samsung/pinctrl-exynos-arm64.c
> @@ -441,6 +441,87 @@ const struct samsung_pinctrl_of_match_data exynos7_of_data __initconst = {
> .num_ctrl = ARRAY_SIZE(exynos7_pin_ctrl),
> };
>
> +/* pin banks of exynos7885 pin-controller 0 (ALIVE) */
> +static const struct samsung_pin_bank_data exynos7885_pin_banks0[] = {
Please take existing code as an example. You missed here and all other
places the initconst.
Best regards,
Krzysztof
Powered by blists - more mailing lists