lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Sun, 31 Oct 2021 22:02:00 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
To:     Paul Cercueil <paul@...pouillou.net>,
        Rob Herring <robh+dt@...nel.org>
Cc:     devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: dts: exynos/i9100: Fix Bluetooth node

On 30/10/2021 14:14, Paul Cercueil wrote:
> The reset GPIO was marked active-high, which is against what's specified
> in the documentation. Mark the reset GPIO as active-low. With this
> change, Bluetooth can now be used on the i9100.
> 
> Also switch away from using the deprecated 'host-wakeup-gpios' property,
> and use a 'host-wakeup' interrupt instead.
> 
> Signed-off-by: Paul Cercueil <paul@...pouillou.net>

Thanks for the patch, but please split it into two commits and add a
"Fixes" tag for the "reset-gpios" one.

All rest looks good, nice patch!

Best regards,
Krzysztof

Powered by blists - more mailing lists