linux-kernel - Re: [PATCH 1/1] staging: vchiq: Replace global state with per device state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 2 Nov 2021 00:45:38 +0800
From:   kernel test robot <lkp@...el.com>
To:     Ojaswin Mujoo <ojaswin98@...il.com>, nsaenz@...nel.org,
        gregkh@...uxfoundation.org, stefan.wahren@...e.com
Cc:     kbuild-all@...ts.01.org, dan.carpenter@...cle.com,
        phil@...pberrypi.com, linux-arm-kernel@...ts.infradead.org,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] staging: vchiq: Replace global state with per device
 state

Hi Ojaswin,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on staging/staging-testing]
[also build test WARNING on next-20211101]
[cannot apply to v5.15]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Ojaswin-Mujoo/vchiq-Replacing-global-structs-with-per-device/20211101-191153
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 10508ae08ed8ce8794785194ad7309f1437d43fd
config: arc-randconfig-r043-20211101 (attached as .config)
compiler: arceb-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/7f81de8bb73f7a7d9d0a0898dbe0144d40e39254
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Ojaswin-Mujoo/vchiq-Replacing-global-structs-with-per-device/20211101-191153
        git checkout 7f81de8bb73f7a7d9d0a0898dbe0144d40e39254
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=arc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:465:5: warning: no previous prototype for 'vchiq_platform_init' [-Wmissing-prototypes]
     465 | int vchiq_platform_init(struct platform_device *pdev, struct vchiq_state *state)
         |     ^~~~~~~~~~~~~~~~~~~
   drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:593:1: warning: no previous prototype for 'vchiq_platform_get_arm_state' [-Wmissing-prototypes]
     593 | vchiq_platform_get_arm_state(struct vchiq_state *state)
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
   In file included from drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:33:
   drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c: In function 'service_callback':
>> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h:106:33: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
     106 | #define DEBUG_INITIALISE(local) int *debug_ptr = (local)->debug
         |                                 ^~~
   drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1086:9: note: in expansion of macro 'DEBUG_INITIALISE'
    1086 |         DEBUG_INITIALISE(state->local);
         |         ^~~~~~~~~~~~~~~~
   drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c: In function 'vchiq_probe':
   drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1845:37: error: passing argument 1 of 'vchiq_register_chrdev' from incompatible pointer type [-Werror=incompatible-pointer-types]
    1845 |         err = vchiq_register_chrdev(vchiq_dev);
         |                                     ^~~~~~~~~
         |                                     |
         |                                     struct vchiq_device *
   In file included from drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:35:
   drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.h:142:56: note: expected 'struct device *' but argument is of type 'struct vchiq_device *'
     142 | static inline int vchiq_register_chrdev(struct device *parent) { return 0; }
         |                                         ~~~~~~~~~~~~~~~^~~~~~
   cc1: some warnings being treated as errors


vim +106 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h

71bad7f086419d popcornmix      2013-07-02  105  
8dd56723240e43 Gaston Gonzalez 2021-10-24 @106  #define DEBUG_INITIALISE(local) int *debug_ptr = (local)->debug
71bad7f086419d popcornmix      2013-07-02  107  #define DEBUG_TRACE(d) \
35b7ebda57affc Michael Zoran   2016-10-19  108  	do { debug_ptr[DEBUG_ ## d] = __LINE__; dsb(sy); } while (0)
71bad7f086419d popcornmix      2013-07-02  109  #define DEBUG_VALUE(d, v) \
35b7ebda57affc Michael Zoran   2016-10-19  110  	do { debug_ptr[DEBUG_ ## d] = (v); dsb(sy); } while (0)
71bad7f086419d popcornmix      2013-07-02  111  #define DEBUG_COUNT(d) \
35b7ebda57affc Michael Zoran   2016-10-19  112  	do { debug_ptr[DEBUG_ ## d]++; dsb(sy); } while (0)
71bad7f086419d popcornmix      2013-07-02  113  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (34411 bytes)