linux-kernel - Re: [PATCH] cgroup: Fix rootcg cpu.stat guest double counting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YYAaWaYzyqloDRQY@slm.duckdns.org>
Date:   Mon, 1 Nov 2021 06:48:25 -1000
From:   Tejun Heo <tj@...nel.org>
To:     Dan Schatzberg <schatzberg.dan@...il.com>
Cc:     Zefan Li <lizefan.x@...edance.com>,
        Johannes Weiner <hannes@...xchg.org>,
        Boris Burkov <boris@....io>,
        "open list:CONTROL GROUP (CGROUP)" <cgroups@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cgroup: Fix rootcg cpu.stat guest double counting

On Thu, Oct 28, 2021 at 03:15:27PM -0700, Dan Schatzberg wrote:
> In account_guest_time in kernel/sched/cputime.c guest time is
> attributed to both CPUTIME_NICE and CPUTIME_USER in addition to
> CPUTIME_GUEST_NICE and CPUTIME_GUEST respectively. Therefore, adding
> both to calculate usage results in double counting any guest time at
> the rootcg.
> 
> Fixes: 936f2a70f207 ("cgroup: add cpu.stat file to root cgroup")
> Signed-off-by: Dan Schatzberg <schatzberg.dan@...il.com>

Applying to cgroup/for-5.16.

Thanks.

-- 
tejun