linux-kernel - Re: [PATCH v2 1/6] KVM: x86: SVM: add module param to control LBR virtualization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87pmrjkfs9.fsf@vitty.brq.redhat.com>
Date:   Mon, 01 Nov 2021 17:21:42 +0100
From:   Vitaly Kuznetsov <vkuznets@...hat.com>
To:     Maxim Levitsky <mlevitsk@...hat.com>, kvm@...r.kernel.org
Cc:     Shuah Khan <shuah@...nel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@...r.kernel.org>, Borislav Petkov <bp@...en8.de>,
        Paolo Bonzini <pbonzini@...hat.com>,
        "open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)" 
        <linux-kernel@...r.kernel.org>, Joerg Roedel <joro@...tes.org>,
        "H. Peter Anvin" <hpa@...or.com>,
        Maxim Levitsky <mlevitsk@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Bandan Das <bsd@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Sean Christopherson <seanjc@...gle.com>,
        Wei Huang <wei.huang2@....com>,
        "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@...nel.org>,
        Ingo Molnar <mingo@...hat.com>
Subject: Re: [PATCH v2 1/6] KVM: x86: SVM: add module param to control LBR
 virtualization

Maxim Levitsky <mlevitsk@...hat.com> writes:

> This is useful for debug and also makes it consistent with
> the rest of the SVM optional features.
>
> Signed-off-by: Maxim Levitsky <mlevitsk@...hat.com>
> ---
>  arch/x86/kvm/svm/svm.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c
> index 21bb81710e0f6..2b5f8e10d686d 100644
> --- a/arch/x86/kvm/svm/svm.c
> +++ b/arch/x86/kvm/svm/svm.c
> @@ -186,12 +186,13 @@ module_param(vls, int, 0444);
>  static int vgif = true;
>  module_param(vgif, int, 0444);
>  
> +static int tsc_scaling = true;
> +module_param(tsc_scaling, int, 0444);
> +
>  /* enable/disable LBR virtualization */
>  static int lbrv = true;
>  module_param(lbrv, int, 0444);
>  
> -static int tsc_scaling = true;
> -module_param(tsc_scaling, int, 0444);

Subject line says "KVM: x86: SVM: add module param to control LBR
virtualization" but the patch just moves 'tsc_scaling' param a couple
lines up. Was this intended or is this a rebase artifact and the patch
just needs to be dropped?

>  
>  /*
>   * enable / disable AVIC.  Because the defaults differ for APICv

-- 
Vitaly