linux-kernel - Re: [RFC v2 0/2] mmc_fixup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <B797E225-B589-4AB5-B62A-6EF8BCADE9B1@goldelico.com>
Date:   Tue, 2 Nov 2021 14:13:13 +0100
From:   "H. Nikolaus Schaller" <hns@...delico.com>
To:     Jérôme Pouiller <jerome.pouiller@...abs.com>
Cc:     Ulf Hansson <ulf.hansson@...aro.org>,
        Avri Altman <avri.altman@....com>,
        Shawn Lin <shawn.lin@...k-chips.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Tony Lindgren <tony@...mide.com>,
        Bean Huo <beanhuo@...ron.com>,
        Gražvydas Ignotas <notasas@...il.com>,
        linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org,
        letux-kernel@...nphoenux.org, kernel@...a-handheld.com
Subject: Re: [RFC v2 0/2] mmc_fixup_device

Hi Jerome,

> Am 02.11.2021 um 12:14 schrieb Jérôme Pouiller <jerome.pouiller@...abs.com>:
> 
> Hello Nikolaus,
> 
> On Monday 1 November 2021 10:39:10 CET H. Nikolaus Schaller wrote:
>> 
>> RFC V2 2021-11-01 10:24:26:
>> * reworked to not misuse mmc_select_card() but add a call to
>>  mmc_fixup_device() right after where host->ops->init_card
>>  was called before to apply the wl1251 specific quirks.
>>  Device tree matching is done by a new table passed to mmc_fixup_device().
>>  suggested by: ulf.hansson@...aro.org
>>  based on patches by: jerome.pouiller@...abs.com
> 
> To make review easier, I think you can include these patches
> in this series (BTW, I have no time to care of them until end
> of next week. So, it will probably go faster if you take over
> these patches).

Ok, no problem.

Now as I understand how it should be set up I could even propose
some new macro for discussion.

> 
> (I also suggest to add a title to your series to make your work
> easier to track.)

Yes... I didn't notice before I received my copy of this mail.
There is a missing if(strlen(subject) == 0) reject; in my helper
tool...

BR and thanks,
Nikolaus