linux-kernel - Re: [PATCH 28/29] drm/i915/gvt: convert to use vfio_register_group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211102164136.GI2744544@nvidia.com>
Date:   Tue, 2 Nov 2021 13:41:36 -0300
From:   Jason Gunthorpe <jgg@...dia.com>
To:     Christoph Hellwig <hch@....de>
Cc:     Jani Nikula <jani.nikula@...ux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@...el.com>,
        Zhenyu Wang <zhenyuw@...ux.intel.com>,
        Zhi Wang <zhi.a.wang@...el.com>,
        intel-gfx@...ts.freedesktop.org,
        intel-gvt-dev@...ts.freedesktop.org,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 28/29] drm/i915/gvt: convert to use
 vfio_register_group_dev()

On Tue, Nov 02, 2021 at 08:06:00AM +0100, Christoph Hellwig wrote:
> This is straightforward conversion, the intel_vgpu already has a pointer
> to the vfio_dev, which can be replaced with the embedded structure and
> we can replace all the mdev_get_drvdata() with a simple container_of().

This should be using vfio_register_emulated_iommu_dev(), right?

I expect drivers using the pin API to use the emulated_iommu_dev()
interface at least..

Otherwise this looks good

Reviewed-by: Jason Gunthorpe <jgg@...dia.com>

Jason