[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <8a00ea68-4859-fbcc-6292-909a66b0a188@perex.cz>
Date: Wed, 3 Nov 2021 09:50:40 +0100
From: Jaroslav Kysela <perex@...ex.cz>
To: Sameer Pujar <spujar@...dia.com>, broonie@...nel.org,
lgirdwood@...il.com, tiwai@...e.com
Cc: thierry.reding@...il.com, jonathanh@...dia.com,
alsa-devel@...a-project.org, linux-tegra@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/4] Fix kcontrol put callback in Tegra drivers
On 03. 11. 21 6:04, Sameer Pujar wrote:
> This series fixes kcontrol put callback in some of the Tegra drivers
> which are used on platforms based on Tegra210 and later. The callback
> is expected to return 1 whenever the HW update is done.
The logic is a little bit another. The 1 means change, so you should compare
the register / cached value and return 1 only when a different value is set.
Your implementation invokes the change events for duplicate updates.
Jaroslav
--
Jaroslav Kysela <perex@...ex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
Powered by blists - more mailing lists