linux-kernel - Re: [PATCH 0/4] Fix kcontrol put callback in Tegra drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1b63798e-cf3f-5ef8-1950-3111273ad82d@nvidia.com>
Date:   Wed, 3 Nov 2021 16:59:08 +0530
From:   Sameer Pujar <spujar@...dia.com>
To:     Jaroslav Kysela <perex@...ex.cz>, broonie@...nel.org,
        lgirdwood@...il.com, tiwai@...e.com
Cc:     thierry.reding@...il.com, jonathanh@...dia.com,
        alsa-devel@...a-project.org, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/4] Fix kcontrol put callback in Tegra drivers



On 11/3/2021 2:20 PM, Jaroslav Kysela wrote:
> External email: Use caution opening links or attachments
>
>
> On 03. 11. 21 6:04, Sameer Pujar wrote:
>> This series fixes kcontrol put callback in some of the Tegra drivers
>> which are used on platforms based on Tegra210 and later. The callback
>> is expected to return 1 whenever the HW update is done.
>
> The logic is a little bit another. The 1 means change, so you should 
> compare
> the register / cached value and return 1 only when a different value 
> is set.
> Your implementation invokes the change events for duplicate updates.

Sorry, I did not think the about duplicate updates. Thanks for the 
suggestion.