linux-kernel - Re: [PATCH 1/9] Remove unused headers <linux/jz4740-adc.h> and <linux/power/jz4740-battery.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YYJg5WaO+Ogd3chz@google.com>
Date:   Wed, 3 Nov 2021 10:13:57 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     Paul Cercueil <paul@...pouillou.net>
Cc:     Jonathan Corbet <corbet@....net>, linux-kernel@...r.kernel.org,
        Paul Burton <paul.burton@...s.com>,
        Sebastian Reichel <sre@...nel.org>, linux-pm@...r.kernel.org
Subject: Re: [PATCH 1/9] Remove unused headers <linux/jz4740-adc.h> and
 <linux/power/jz4740-battery.h>

On Wed, 03 Nov 2021, Paul Cercueil wrote:

> Hi Lee,
> 
> Le mer., nov. 3 2021 at 07:43:51 +0000, Lee Jones <lee.jones@...aro.org> a
> écrit :
> > On Tue, 02 Nov 2021, Jonathan Corbet wrote:
> > 
> > >  Commit ff71266aa490 ("mfd: Drop obsolete JZ4740 driver") removed
> > > the last
> > >  file to include <linux/jz4740-adc.h> but left the header file itself
> > >  behind.  Nothing uses it, remove it now.
> > > 
> > >  Similarly, aea12071d6fc ("power/supply: Drop obsolete JZ4740
> > > driver")
> > >  deleted the last use of <linux/power/jz4740-battery.h>, so remove
> > > that one
> > >  too.
> > > 
> > >  Cc: Paul Cercueil <paul@...pouillou.net>
> > >  Cc: Lee Jones <lee.jones@...aro.org>
> > >  Cc: Paul Burton <paul.burton@...s.com>
> > >  Cc: Sebastian Reichel <sre@...nel.org>
> > >  Cc: linux-pm@...r.kernel.org
> > >  Signed-off-by: Jonathan Corbet <corbet@....net>
> > >  ---
> > >   include/linux/jz4740-adc.h           | 33
> > > ----------------------------
> > >   include/linux/power/jz4740-battery.h | 15 -------------
> > 
> > It appears as though there are still references to both of these
> > *devices* in the kernel tree.  Should those be removed also?
> 
> These files were for older drivers that were since then replaced by newer
> drivers; JZ47xx SoCs are still officially supported and maintained.

Okay, great.

Thanks for the explanation Paul.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog