linux-kernel - Re: [PATCH 1/9] Remove unused headers <linux/jz4740-adc.h> and <linux/power/jz4740-battery.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211103124046.te5rfhfvkbw2tby3@earth.universe>
Date:   Wed, 3 Nov 2021 13:40:46 +0100
From:   Sebastian Reichel <sre@...nel.org>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     Jonathan Corbet <corbet@....net>, linux-kernel@...r.kernel.org,
        Paul Cercueil <paul@...pouillou.net>,
        Paul Burton <paul.burton@...s.com>, linux-pm@...r.kernel.org
Subject: Re: [PATCH 1/9] Remove unused headers <linux/jz4740-adc.h> and
 <linux/power/jz4740-battery.h>

Hi,

On Wed, Nov 03, 2021 at 07:43:51AM +0000, Lee Jones wrote:
> On Tue, 02 Nov 2021, Jonathan Corbet wrote:
> > Commit ff71266aa490 ("mfd: Drop obsolete JZ4740 driver") removed the last
> > file to include <linux/jz4740-adc.h> but left the header file itself
> > behind.  Nothing uses it, remove it now.
> > 
> > Similarly, aea12071d6fc ("power/supply: Drop obsolete JZ4740 driver")
> > deleted the last use of <linux/power/jz4740-battery.h>, so remove that one
> > too.

Thanks for the cleanup Jonathan.

> > Cc: Paul Cercueil <paul@...pouillou.net>
> > Cc: Lee Jones <lee.jones@...aro.org>
> > Cc: Paul Burton <paul.burton@...s.com>
> > Cc: Sebastian Reichel <sre@...nel.org>
> > Cc: linux-pm@...r.kernel.org
> > Signed-off-by: Jonathan Corbet <corbet@....net>
> > ---
> >  include/linux/jz4740-adc.h           | 33 ----------------------------
> >  include/linux/power/jz4740-battery.h | 15 -------------
> 
> It appears as though there are still references to both of these
> *devices* in the kernel tree.  Should those be removed also?
> 
> >  2 files changed, 48 deletions(-)
> >  delete mode 100644 include/linux/jz4740-adc.h
> >  delete mode 100644 include/linux/power/jz4740-battery.h
> 
> Patch looks fine though.
> 
> Let me know if you want me to take it in via MFD.  Otherwise:
> 
> Acked-by: Lee Jones <lee.jones@...aro.org>

You can take it through MFD, no immutable branch needed.

Acked-by: Sebastian Reichel <sebastian.reichel@...labora.com>

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)