lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 3 Nov 2021 15:04:48 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Kushal Kothari <kushalkothari285@...il.com>
Cc:     gregkh@...uxfoundation.org, kush19992810@...il.com,
        outreachy-kernel@...glegroups.com, fabioaiuto83@...il.com,
        ross.schm.dev@...il.com, fmdefrancesco@...il.com,
        marcocesati@...il.com, straube.linux@...il.com,
        philippesdixon@...il.com, manuelpalenzuelamerino@...il.com,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        mike.rapoport@...il.com, kushalkotharitest@...glegroups.com
Subject: Re: [PATCH v4 3/4] staging: rtl8723bs: core: Remove unnecessary
 space after a cast

This v4 patchset look good.  Thanks!

On Sat, Oct 23, 2021 at 01:05:49PM +0530, Kushal Kothari wrote:
> @@ -2027,7 +2027,7 @@ void rtw_setstaKey_cmdrsp_callback(struct adapter *padapter,  struct cmd_obj *pc
>  {
>  
>  	struct sta_priv *pstapriv = &padapter->stapriv;
> -	struct set_stakey_rsp *psetstakey_rsp = (struct set_stakey_rsp *) (pcmd->rsp);
> +	struct set_stakey_rsp *psetstakey_rsp = (struct set_stakey_rsp *)(pcmd->rsp);
                                                                         ^^^^^^^^^^^
An unrelated note, if you wanted to send more patches.  These extra
parentheses could be removed.

>  	struct sta_info *psta = rtw_get_stainfo(pstapriv, psetstakey_rsp->addr);
>  
>  	if (!psta)
> @@ -2042,7 +2042,7 @@ void rtw_setassocsta_cmdrsp_callback(struct adapter *padapter,  struct cmd_obj *
>  	struct sta_priv *pstapriv = &padapter->stapriv;
>  	struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
>  	struct set_assocsta_parm *passocsta_parm = (struct set_assocsta_parm *)(pcmd->parmbuf);
                                                                               ^^^^^^^^^^^^^^^
Same here.

> -	struct set_assocsta_rsp *passocsta_rsp = (struct set_assocsta_rsp *) (pcmd->rsp);
> +	struct set_assocsta_rsp *passocsta_rsp = (struct set_assocsta_rsp *)(pcmd->rsp);
                                                                            ^^^^^^^^^^^^
Here.

>  	struct sta_info *psta = rtw_get_stainfo(pstapriv, passocsta_parm->addr);
>  
>  	if (!psta)

regards,
dan carpenter

Powered by blists - more mailing lists