linux-kernel - Re: [PATCH] ASoC: amd: vangogh: add SPI dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 3 Nov 2021 09:15:40 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Arnd Bergmann <arnd@...nel.org>, Mark Brown <broonie@...nel.org>
Cc:     Arnd Bergmann <arnd@...db.de>, Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Vijendar Mukunda <Vijendar.Mukunda@....com>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Ajit Kumar Pandey <AjitKumar.Pandey@....com>,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: amd: vangogh: add SPI dependency

On 10/19/21 12:14 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> Without CONFIG_SPI, this fails to build:
> 
> WARNING: unmet direct dependencies detected for SND_SOC_CS35L41_SPI
>    Depends on [n]: SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SPI_MASTER [=n]
>    Selected by [m]:
>    - SND_SOC_AMD_VANGOGH_MACH [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_SOC_AMD_ACP5x [=m] && I2C [=y]
> ERROR: modpost: "spi_setup" [sound/soc/codecs/snd-soc-cs35l41-spi.ko] undefined!
> ERROR: modpost: "__devm_regmap_init_spi" [sound/soc/codecs/snd-soc-cs35l41-spi.ko] undefined!
> 
> Fixes: 96792fdd77cd ("ASoC: amd: enable vangogh platform machine driver build")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>   sound/soc/amd/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig
> index d91a9399777c..edee2098c82e 100644
> --- a/sound/soc/amd/Kconfig
> +++ b/sound/soc/amd/Kconfig
> @@ -68,7 +68,7 @@ config SND_SOC_AMD_VANGOGH_MACH
>   	tristate "AMD Vangogh support for NAU8821 CS35L41"
>   	select SND_SOC_NAU8821
>   	select SND_SOC_CS35L41_SPI
> -	depends on SND_SOC_AMD_ACP5x && I2C
> +	depends on SND_SOC_AMD_ACP5x && I2C && SPI
>   	help
>   	  This option enables machine driver for Vangogh platform
>   	  using NAU8821 and CS35L41 codecs.
> 

Reviewed-by: Randy Dunlap <rdunlap@...radead.org>

Just had this build error in linux-next-20211103
so this patch is needed there.

Thanks.

-- 
~Randy