linux-kernel - Re: [PATCH] powerpc: use swap() to make code cleaner

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211105072618.4afd84a9@canb.auug.org.au>
Date:   Fri, 5 Nov 2021 07:26:18 +1100
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     Segher Boessenkool <segher@...nel.crashing.org>
Cc:     davidcomponentone@...il.com, sxwjean@...il.com,
        Zeal Robot <zealci@....com.cn>, linux-kernel@...r.kernel.org,
        nathan@...nel.org, yang.guang5@....com.cn, paulus@...ba.org,
        aneesh.kumar@...ux.ibm.com, linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH] powerpc: use swap() to make code cleaner

Hi Segher,

On Thu, 4 Nov 2021 06:33:51 -0500 Segher Boessenkool <segher@...nel.crashing.org> wrote:
>
> On Thu, Nov 04, 2021 at 09:06:56PM +1100, Stephen Rothwell wrote:
> > On Thu,  4 Nov 2021 14:17:09 +0800 davidcomponentone@...il.com wrote:  
> > > From: Yang Guang <yang.guang5@....com.cn>
> > > 
> > > Use the macro 'swap()' defined in 'include/linux/minmax.h' to avoid
> > > opencoding it.  
> > 
> > So if swap() is in the above include file, then you should include it.  
> 
> It is included from kernel.h already (which is included from delay.h).

And that becomes a pain when include files get "cleaned up". :-(

$ grep kernel.h include/linux/delay.h
$

See commit

  300424acf349 ("include/linux/delay.h: replace kernel.h with the necessary inclusions")

currently pending the Andrew Morton's patch queue (the above is a
linux-next commit).
-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped