linux-kernel - Re: [PATCH 2/2] mmc: Add mmc driver for Sunplus SP7021

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3da7cacf-d5ab-9f08-6d15-a75cf952d43d@infradead.org>
Date:   Sat, 6 Nov 2021 08:16:10 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Tony Huang <tonyhuang.sunplus@...il.com>, ulf.hansson@...aro.org,
        robh+dt@...nel.org, linux-mmc@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        p.zabel@...gutronix.de
Cc:     wells.lu@...plus.com, Tony Huang <tony.huang@...plus.com>
Subject: Re: [PATCH 2/2] mmc: Add mmc driver for Sunplus SP7021

[resending, had some kind of email error on the first try]

On 11/6/21 7:23 AM, Tony Huang wrote:
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index ccc148c..2a78cbc 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -14,6 +14,15 @@ config MMC_DEBUG
>   	  added host drivers please don't invent their private macro for
>   	  debugging.
>   
> +config MMC_SUNPLUS
> +	tristate "Sunplus SP7021 MMC Controller"
> +	depends on ARCH_SUNPLUS || SOC_I143 || SOC_Q645
> +	default y

Is this needed to be able to boot?  That's about the only
reason that "default y" could be justified.

> +	help
> +		If you say yes here, you will get support for eMMC host interface
> +		on sunplus Socs.

		   Sunplus SoCs.

> +		If unsure, say N.
> +		Sunplus  eMMC Host Controller v4.51 support"

What is that last line for?

And all lines of the help text should be indented with
one tab + 2 spaces per coding-style.rst.

thanks.
-- 
~Randy