linux-kernel - Re: [PATCH] pinctrl: qcom: sm8350: Correct UFS and SDC offsets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 6 Nov 2021 19:08:26 +0200
From:   Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Vinod Koul <vkoul@...nel.org>
Cc:     linux-arm-msm@...r.kernel.org, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pinctrl: qcom: sm8350: Correct UFS and SDC offsets

On 11/4/21 7:08 PM, Bjorn Andersson wrote:
> The downstream TLMM binding covers a group of TLMM-related hardware
> blocks, but the upstream binding only captures the particular block
> related to controlling the TLMM pins from an OS. In the translation of
> the driver from downstream, the offset of 0x100000 was lost for the UFS
> and SDC pingroups.
> 
> Fixes: d5d348a3271f ("pinctrl: qcom: Add SM8350 pinctrl driver")
> Signed-off-by: Bjorn Andersson <bjorn.andersson@...aro.org>
> ---
>   drivers/pinctrl/qcom/pinctrl-sm8350.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/pinctrl/qcom/pinctrl-sm8350.c b/drivers/pinctrl/qcom/pinctrl-sm8350.c
> index 4d8f8636c2b3..1c042d39380c 100644
> --- a/drivers/pinctrl/qcom/pinctrl-sm8350.c
> +++ b/drivers/pinctrl/qcom/pinctrl-sm8350.c
> @@ -1597,10 +1597,10 @@ static const struct msm_pingroup sm8350_groups[] = {
>   	[200] = PINGROUP(200, qdss_gpio, _, _, _, _, _, _, _, _),
>   	[201] = PINGROUP(201, _, _, _, _, _, _, _, _, _),
>   	[202] = PINGROUP(202, _, _, _, _, _, _, _, _, _),
> -	[203] = UFS_RESET(ufs_reset, 0x1d8000),
> -	[204] = SDC_PINGROUP(sdc2_clk, 0x1cf000, 14, 6),
> -	[205] = SDC_PINGROUP(sdc2_cmd, 0x1cf000, 11, 3),
> -	[206] = SDC_PINGROUP(sdc2_data, 0x1cf000, 9, 0),
> +	[203] = UFS_RESET(ufs_reset, 0xd8000),
> +	[204] = SDC_PINGROUP(sdc2_clk, 0xcf000, 14, 6),
> +	[205] = SDC_PINGROUP(sdc2_cmd, 0xcf000, 11, 3),
> +	[206] = SDC_PINGROUP(sdc2_data, 0xcf000, 9, 0),
>   };
>   
>   static const struct msm_gpio_wakeirq_map sm8350_pdc_map[] = {
> 

Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>

--
Best wishes,
Vladimir