linux-kernel - Re: [PATCH 0/9] arm64: dts: renesas: Thermal binding validation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YYo62jdzSTxqCMtk@oden.dyn.berto.se>
Date:   Tue, 9 Nov 2021 10:09:46 +0100
From:   Niklas Söderlund 
        <niklas.soderlund+renesas@...natech.se>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Kieran Bingham <kieran.bingham+renesas@...asonboard.com>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>
Subject: Re: [PATCH 0/9] arm64: dts: renesas: Thermal binding validation

On 2021-11-09 09:43:33 +0100, Niklas Söderlund wrote:
> > > linux/arch/arm64/boot/dts/renesas/r8a77951-ulcb-kf.dt.yaml: 
> > > thermal-zones: sensor3-thermal:cooling-maps:map0:contribution:0:0: 
> > > 1024 is greater than the maximum of 100
> > >         From schema: Documentation/devicetree/bindings/thermal/thermal-zones.yaml
> > >
> > > This validation error appears to be pervasive across all of these
> > > bindings, but changing that will be more invasive and require someone to
> > > perform dedicated testing with the thermal drivers to ensure that the
> > > updates to the ranges do not cause unexpected side effects.
> > 
> > Niklas?
> 
> I will have a look. The thermal driver is the one driver where I have 
> automated CI test running.

So the core of the issue is that the definition of the property changed 
in the txt to yaml conversion. The original definition was,

  Optional property:
  - contribution:         The cooling contribution to the thermal zone of the
    Type: unsigned        referred cooling device at the referred trip point.
    Size: one cell        The contribution is a ratio of the sum
			    of all cooling contributions within a thermal zone.

While the  new binding states,

  contribution:
    $ref: /schemas/types.yaml#/definitions/uint32
    minimum: 0
    maximum: 100 
    description:
      The percentage contribution of the cooling devices at the 
      specific trip temperature referenced in this map 
      to this thermal zone

Looking at the real world usage of this only 2 out of 17 platforms sets 
a contribution value less or equal to 100. I will send a patch to fix 
the bindings.

-- 
Kind Regards,
Niklas Söderlund