linux-kernel - Re: [PATCH 0/9] arm64: dts: renesas: Thermal binding validation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 9 Nov 2021 09:43:31 +0100
From:   Niklas Söderlund 
        <niklas.soderlund+renesas@...natech.se>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Kieran Bingham <kieran.bingham+renesas@...asonboard.com>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>
Subject: Re: [PATCH 0/9] arm64: dts: renesas: Thermal binding validation

Hello,

On 2021-11-09 09:29:01 +0100, Geert Uytterhoeven wrote:
> Hi Kieran,
> 
> On Thu, Nov 4, 2021 at 11:40 PM Kieran Bingham
> <kieran.bingham+renesas@...asonboard.com> wrote:
> > The thermal sensor bindings were not matched correctly against the
> > expected naming scheme.
> >
> > r8a77980.dtsi also used a different naming scheme compared to the other
> > related platforms.
> 
> It lacked the labels, which you added for consistency.
> Is there any point in providing them, as there are no users? Or should
> they be removed instead?
> 
> > This series cleans up the dtsi files for the CPU target thermal sensors,
> > allowing the validation to run.
> >
> > Enabling this validation shows up a new validation failure:
> >
> > linux/arch/arm64/boot/dts/renesas/r8a77951-ulcb-kf.dt.yaml: thermal-zones: sensor3-thermal:cooling-maps:map0:contribution:0:0: 1024 is greater than the maximum of 100
> >         From schema: Documentation/devicetree/bindings/thermal/thermal-zones.yaml
> >
> > This validation error appears to be pervasive across all of these
> > bindings, but changing that will be more invasive and require someone to
> > perform dedicated testing with the thermal drivers to ensure that the
> > updates to the ranges do not cause unexpected side effects.
> 
> Niklas?

I will have a look. The thermal driver is the one driver where I have 
automated CI test running.

> 
> > Kieran Bingham (9):
> >   arm64: dts: renesas: r8a774a1: Fix thermal bindings
> >   arm64: dts: renesas: r8a774b1: Fix thermal bindings
> >   arm64: dts: renesas: r8a774e1: Fix thermal bindings
> >   arm64: dts: renesas: r8a77951: Fix thermal bindings
> >   arm64: dts: renesas: r8a77960: Fix thermal bindings
> >   arm64: dts: renesas: r8a77961: Fix thermal bindings
> >   arm64: dts: renesas: r8a77965: Fix thermal bindings
> >   arm64: dts: renesas: r8a77980: Fix thermal bindings
> >   arm64: dts: renesas: r8a779a0: Fix thermal bindings
> 
> For the whole series:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>

Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@...natech.se>

> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

-- 
Kind Regards,
Niklas Söderlund