[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20211109091951.GW3891@suse.de>
Date: Tue, 9 Nov 2021 09:19:51 +0000
From: Mel Gorman <mgorman@...e.de>
To: ?????? <ligang.bdlg@...edance.com>
Cc: Jonathan Corbet <corbet@....net>, Ingo Molnar <mingo@...hat.com>,
Peter Zijlstra <peterz@...radead.org>,
Juri Lelli <juri.lelli@...hat.com>,
Vincent Guittot <vincent.guittot@...aro.org>,
Dietmar Eggemann <dietmar.eggemann@....com>,
Steven Rostedt <rostedt@...dmis.org>,
Ben Segall <bsegall@...gle.com>,
Daniel Bristot de Oliveira <bristot@...hat.com>,
linux-api@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
linux-fsdevel@...r.kernel.org, linux-doc@...r.kernel.org
Subject: Re: Re: Re: [PATCH v1] sched/numa: add per-process numa_balancing
On Tue, Nov 09, 2021 at 04:28:28PM +0800, ?????? wrote:
> Hi, sorry for the late reply.
>
> On Fri, Oct 29, 2021 at 4:37 PM Mel Gorman <mgorman@...e.de> wrote:
> >
> > My point is that as it stands,
> > prctl(PR_NUMA_BALANCING,PR_SET_NUMA_BALANCING,1) either does nothing or
> > fails. If per-process numa balancing is to be introduced, it should have
> > meaning with the global tuning affecting default behaviour and the prctl
> > affecting specific behaviour.
> >
>
> If the global tuning affects default behaviour and the prctl
> affects specific behaviour. Then when prctl specifies
> numa_balancing for a process, there is no way for the
> global tuning to affect that process.
Yes.
> In other words, global tuning
> become a default value, not a switch for global numa_balancing.
>
Also yes. The global tuning becomes "all processes default to using NUMA
balancing unless overridden by prctl".
The main difficulty is that one task using prctl to enable NUMA balancing
needs to enable the static branch so there is a small global hit.
> My idea is that the global numa_balancning still has absolute control, and prctl
> can only optionally turn off numa_balancing for process when the global is on.
> After all, It is more common to enable global numa_balancing and disable it in
> several processes than to disable global numa_balancing and enable it in
> several processes.
Then this comment would still apply
My point is that as it stands,
prctl(PR_NUMA_BALANCING,PR_SET_NUMA_BALANCING,1) either does nothing
or fails.
While I think it's very likely that the common case will be to disable
NUMA balancing for specific processes,
prctl(PR_NUMA_BALANCING,PR_SET_NUMA_BALANCING,1) should still be
meaningful.
--
Mel Gorman
SUSE Labs
Powered by blists - more mailing lists