linux-kernel - Re: [PATCH] drivers:gpio: Remove unneeded semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211109092123.ao6x4imbx5zg4pl2@vireshk-i7>
Date:   Tue, 9 Nov 2021 14:51:23 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     cgel.zte@...il.com
Cc:     info@...ux.net, vireshk@...nel.org, linus.walleij@...aro.org,
        brgl@...ev.pl, linux-gpio@...r.kernel.org,
        virtualization@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org, chiminghao <chi.minghao@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH] drivers:gpio: Remove unneeded semicolon

On 09-11-21, 08:23, cgel.zte@...il.com wrote:
> From: chiminghao <chi.minghao@....com.cn>
> 
> Fix the following coccicheck REVIEW:
> ./drivers/gpio/gpio-virtio.c:437:2-3 REVIEW Unneeded semicolon
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: chiminghao <chi.minghao@....com.cn>
> ---
>  drivers/gpio/gpio-virtio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpio/gpio-virtio.c b/drivers/gpio/gpio-virtio.c
> index aeec4bf0b625..84f96b78f32a 100644
> --- a/drivers/gpio/gpio-virtio.c
> +++ b/drivers/gpio/gpio-virtio.c
> @@ -434,7 +434,7 @@ static void virtio_gpio_event_vq(struct virtqueue *vq)
>  		ret = generic_handle_domain_irq(vgpio->gc.irq.domain, gpio);
>  		if (ret)
>  			dev_err(dev, "failed to handle interrupt: %d\n", ret);
> -	};
> +	}
>  }
>  
>  static void virtio_gpio_request_vq(struct virtqueue *vq)

A similar patch was already reviewed earlier:

https://lore.kernel.org/all/1636344232-56537-1-git-send-email-yang.lee@linux.alibaba.com/

-- 
viresh