linux-kernel - Re: [PATCH 10/13] dt-bindings: spi: add bindings for microchip mpfs spi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <96005893-8819-1d76-6dea-7d173655258f@microchip.com>
Date:   Tue, 9 Nov 2021 12:16:21 +0000
From:   <Conor.Dooley@...rochip.com>
To:     <robh@...nel.org>
CC:     <robh+dt@...nel.org>, <gregkh@...uxfoundation.org>,
        <linus.walleij@...aro.org>, <linux-riscv@...ts.infradead.org>,
        <aou@...s.berkeley.edu>, <paul.walmsley@...ive.com>,
        <linux-usb@...r.kernel.org>, <Daire.McNamara@...rochip.com>,
        <linux-spi@...r.kernel.org>, <geert@...ux-m68k.org>,
        <devicetree@...r.kernel.org>, <linux-rtc@...r.kernel.org>,
        <linux-gpio@...r.kernel.org>, <broonie@...nel.org>,
        <palmer@...belt.com>, <bgolaszewski@...libre.com>,
        <jassisinghbrar@...il.com>, <linux-crypto@...r.kernel.org>,
        <Ivan.Griffin@...rochip.com>, <atish.patra@....com>,
        <Lewis.Hanly@...rochip.com>, <bin.meng@...driver.com>,
        <alexandre.belloni@...tlin.com>,
        <krzysztof.kozlowski@...onical.com>, <linux-i2c@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <a.zummo@...ertech.it>
Subject: Re: [PATCH 10/13] dt-bindings: spi: add bindings for microchip mpfs
 spi

On 09/11/2021 04:06, Rob Herring wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Mon, 08 Nov 2021 15:05:51 +0000, conor.dooley@...rochip.com wrote:
>> From: Conor Dooley <conor.dooley@...rochip.com>
>>
>> Add device tree bindings for the {q,}spi controller on
>> the Microchip PolarFire SoC.
>>
>> Signed-off-by: Conor Dooley <conor.dooley@...rochip.com>
>> ---
>>   .../bindings/spi/microchip,mpfs-spi.yaml      | 72 +++++++++++++++++++
>>   1 file changed, 72 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml
>>
> 
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> Documentation/devicetree/bindings/spi/microchip,mpfs-spi.example.dts:19:18: fatal error: dt-bindings/clock/microchip,mpfs-clock.h: No such file or directory
>     19 |         #include "dt-bindings/clock/microchip,mpfs-clock.h"
Rob,
Should I drop the header from the example or is there a way for me 
specify the dependent patch to pass this check?
>        |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> compilation terminated.
> make[1]: *** [scripts/Makefile.lib:385: Documentation/devicetree/bindings/spi/microchip,mpfs-spi.example.dt.yaml] Error 1
> make[1]: *** Waiting for unfinished jobs....
> make: *** [Makefile:1441: dt_binding_check] Error 2
> 
> doc reference errors (make refcheckdocs):
> 
> See https://patchwork.ozlabs.org/patch/1552385
> 
> This check can fail if there are any dependencies. The base for a patch
> series is generally the most recent rc1.
> 
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit.
>