linux-kernel - Re: [PATCH v3 09/11] dt-bindings: i2c: i2c-imx-lpi2c: Fix dtbs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YYvqswlk59lI0fqH@ryzen>
Date:   Wed, 10 Nov 2021 17:52:19 +0200
From:   Abel Vesa <abel.vesa@....com>
To:     Rob Herring <robh@...nel.org>
Cc:     Dong Aisheng <aisheng.dong@....com>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Fabio Estevam <festevam@...il.com>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        linux-i2c@...r.kernel.org, linux-serial@...r.kernel.org,
        NXP Linux Team <linux-imx@....com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v3 09/11] dt-bindings: i2c: i2c-imx-lpi2c: Fix dtbs_check
 compatible oneOf error

On 21-10-14 15:02:19, Rob Herring wrote:
> On Wed, Oct 06, 2021 at 04:26:02PM +0300, Abel Vesa wrote:
> > Fix following dtbs_check error:
> > 
> > arch/arm64/boot/dts/freescale/imx8qm-mek.dt.yaml:
> > i2c@...00000: compatible: 'oneOf' conditional failed, one must be fixed:
> >         ['fsl,imx8qm-lpi2c', 'fsl,imx7ulp-lpi2c'] is too long
> >         Additional items are not allowed ('fsl,imx7ulp-lpi2c' was
> > unexpected)
> >         'fsl,imx8qxp-lpi2c' was expected
> >         From schema:
> > Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml
> > 
> > Signed-off-by: Abel Vesa <abel.vesa@....com>
> > ---
> >  Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml b/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml
> > index 29b9447f3b84..acf2d5f45f4e 100644
> > --- a/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml
> > +++ b/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml
> > @@ -18,8 +18,11 @@ properties:
> >        - enum:
> >            - fsl,imx7ulp-lpi2c
> >            - fsl,imx8qm-lpi2c
> > +          - fsl,imx8qxp-lpi2c
> 
> Both with and without a fallback should not be valid.
> 
> Why are you changing fsl,imx8qxp-lpi2c when the error was for 
> fsl,imx8qm-lpi2c?
> 

Sorry for the late reply.

I assume the correct way would be like:

    oneOf:                                   
      - enum:                                
          - fsl,imx7ulp-lpi2c                
      - items:                               
	  - enum:                            
	      - fsl,imx8dxl-lpi2c            
	      - fsl,imx8qxp-lpi2c            
	      - fsl,imx8qm-lpi2c             
	  - const: fsl,imx7ulp-lpi2c         
				
Right ?

Since all the possible combinations are:
	compatible = "fsl,imx8dxl-lpi2c", "fsl,imx7ulp-lpi2c";
	compatible = "fsl,imx8qm-lpi2c", "fsl,imx7ulp-lpi2c";
	compatible = "fsl,imx8qxp-lpi2c", "fsl,imx7ulp-lpi2c";
	compatible = "fsl,imx7ulp-lpi2c";


> >        - items:
> > -          - const: fsl,imx8qxp-lpi2c
> > +          - enum:
> > +              - fsl,imx8qm-lpi2c
> > +              - fsl,imx8qxp-lpi2c
> >            - const: fsl,imx7ulp-lpi2c
> >  
> >    reg:
> > -- 
> > 2.31.1
> > 
> >