linux-kernel - Re: [PATCH] ARM: s3c: include header for prototype of s3c2410_modify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 11 Nov 2021 21:58:35 +0530
From:   Alim Akhtar <alim.akhtar@...il.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
Cc:     linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org,
        open list <linux-kernel@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] ARM: s3c: include header for prototype of s3c2410_modify_misccr

Hi Krzysztof,

On Thu, Nov 11, 2021 at 2:42 PM Krzysztof Kozlowski
<krzysztof.kozlowski@...onical.com> wrote:
>
> Include the header with prototype of s3c2410_modify_misccr to fix W=1
> warning:
>
>   arch/arm/mach-s3c/gpio-samsung.c:1309:14: warning:
>     no previous prototype for ‘s3c2410_modify_misccr’ [-Wmissing-prototypes]
>
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
> ---
Reviewed-by: Alim Akhtar <alim.akhtar@...sung.com>

>  arch/arm/mach-s3c/gpio-samsung.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-s3c/gpio-samsung.c b/arch/arm/mach-s3c/gpio-samsung.c
> index 76ef415789f2..fda2c01f5a08 100644
> --- a/arch/arm/mach-s3c/gpio-samsung.c
> +++ b/arch/arm/mach-s3c/gpio-samsung.c
> @@ -35,6 +35,7 @@
>  #include "gpio-core.h"
>  #include "gpio-cfg.h"
>  #include "gpio-cfg-helpers.h"
> +#include "hardware-s3c24xx.h"
>  #include "pm.h"
>
>  int samsung_gpio_setpull_updown(struct samsung_gpio_chip *chip,
> --
> 2.32.0
>


-- 
Regards,
Alim