linux-kernel - Removal of config MACH_FSG and dead reference in LEDS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKXUXMxBW0qM06i7TvFG+8HrwbR1eYR+9Ed648aZ95mtXiA7Tg@mail.gmail.com>
Date:   Fri, 12 Nov 2021 08:58:51 +0100
From:   Lukas Bulwahn <lukas.bulwahn@...il.com>
To:     Linus Walleij <linusw@...nel.org>, Marc Zyngier <maz@...nel.org>,
        Imre Kaloz <kaloz@...nwrt.org>,
        Krzysztof Halasa <khalasa@...p.pl>,
        Russell King <linux@...linux.org.uk>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        kernel-janitors <kernel-janitors@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Removal of config MACH_FSG and dead reference in LEDS_FSG

Dear Linus,

Your commit b71377b3e1e0 ("ARM: ixp4xx: Delete the Freecom FSG-3
boardfiles") removes the config MACH_FSG. Hence, the config LEDS_FSG
and its corresponding driver leds-fsg.c is effectively not selectable.
I do not know much about how with device trees we ensure that specific
drivers are selected, or how Kconfig build dependencies are combined
with device trees properly here. So, I do not know what the right
patch is here.

Was it intended that this code is now made obsolete? Can this driver
really be deleted?

Or does it require just some further adjustment to make the leds-fsg
driver productive again?

This issue was identified with ./scripts/checkkconfigsymbols.py, which
reports the following reference to an undefined config:

  MACH_FSG
  Referencing files: drivers/leds/Kconfig

I am happy to support creating a patch, once I understand what needs
to be done in this case.

Best regards,

Lukas