linux-kernel - Re: Removal of config MACH_FSG and dead reference in LEDS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdYfqrSOJYh9trvcioBAVXZRZsjhNEgxpCNFtpjJCPrMfg@mail.gmail.com>
Date:   Mon, 22 Nov 2021 00:03:57 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Lukas Bulwahn <lukas.bulwahn@...il.com>
Cc:     Linus Walleij <linusw@...nel.org>, Marc Zyngier <maz@...nel.org>,
        Imre Kaloz <kaloz@...nwrt.org>,
        Krzysztof Halasa <khalasa@...p.pl>,
        Russell King <linux@...linux.org.uk>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        kernel-janitors <kernel-janitors@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: Removal of config MACH_FSG and dead reference in LEDS_FSG

On Fri, Nov 12, 2021 at 8:59 AM Lukas Bulwahn <lukas.bulwahn@...il.com> wrote:

> Your commit b71377b3e1e0 ("ARM: ixp4xx: Delete the Freecom FSG-3
> boardfiles") removes the config MACH_FSG. Hence, the config LEDS_FSG
> and its corresponding driver leds-fsg.c is effectively not selectable.
> I do not know much about how with device trees we ensure that specific
> drivers are selected, or how Kconfig build dependencies are combined
> with device trees properly here. So, I do not know what the right
> patch is here.
>
> Was it intended that this code is now made obsolete? Can this driver
> really be deleted?

Oops no.

> Or does it require just some further adjustment to make the leds-fsg
> driver productive again?

Yes. I'll look into it!

Yours,
Linus Walleij