linux-kernel - Re: [PATCH] apparmor: remove duplicated 'Returns:' comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f4447f61-59f2-cfc2-1157-df00175c6a10@canonical.com>
Date:   Thu, 11 Nov 2021 17:25:41 -0800
From:   John Johansen <john.johansen@...onical.com>
To:     Austin Kim <austindh.kim@...il.com>, serge@...lyn.com
Cc:     linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] apparmor: remove duplicated 'Returns:' comments

On 11/3/21 2:25 AM, Austin Kim wrote:
> It might look better if duplicated 'Returns:' comment is removed.
> 
> Signed-off-by: Austin Kim <austindh.kim@...il.com>

sorry, it looks like I forgot to reply to this. I pulled this into the
apparmor tree and it has been merged for 5.16

> ---
>  security/apparmor/procattr.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/security/apparmor/procattr.c b/security/apparmor/procattr.c
> index c929bf4a3df1..fde332e0ea7d 100644
> --- a/security/apparmor/procattr.c
> +++ b/security/apparmor/procattr.c
> @@ -21,8 +21,6 @@
>   * @profile: the profile to print profile info about  (NOT NULL)
>   * @string: Returns - string containing the profile info (NOT NULL)
>   *
> - * Returns: length of @string on success else error on failure
> - *
>   * Requires: profile != NULL
>   *
>   * Creates a string containing the namespace_name://profile_name for
>