linux-kernel - Re: [PATCH v1 1/1] i2c: designware: Fix the kernel doc description for struct dw_i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YZJsUHVhGFsImNvt@smile.fi.intel.com>
Date:   Mon, 15 Nov 2021 16:18:56 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-i2c <linux-i2c@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>
Subject: Re: [PATCH v1 1/1] i2c: designware: Fix the kernel doc description
 for struct dw_i2c_dev

On Fri, Nov 12, 2021 at 08:43:16AM -0800, Randy Dunlap wrote:
> On 11/12/21 8:26 AM, Andy Shevchenko wrote:
> > On Fri, Nov 12, 2021 at 6:01 PM Randy Dunlap <rdunlap@...radead.org> wrote:
> > > On 11/12/21 4:34 AM, Andy Shevchenko wrote:

...

> > > > + * @rinfo: I²C GPIO recovery information
> > > 
> > > Preferably:   "I2C"
> > 
> > Why?
> 
> See below vvvvvvvvvvvvvvvvv:
> > > like it is in thousands of places in the kernel source tree.

When is it good point to start following the spec?

> > UTF-8 has been established for more than a decade. I prefer to use the
> > proper form of the abbreviation (*).
> > 
> > *) Check UM10204.pdf.
> 
> Yes, I am aware of what is in the spec.

Wolfram, what do you prefer?

-- 
With Best Regards,
Andy Shevchenko